mojo/mojo_public.gyp - Issue 2038413003: Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF type…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/mojo_public.gyp

Issue 2038413003: Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF type… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/mojo_public.gyp

diff --git a/mojo/mojo_public.gyp b/mojo/mojo_public.gyp

index 901b2aca3a3d51c419519074139f9e23723698b8..7f512fc8b9ba6fbf3a412434f27382d0e32456aa 100644

--- a/mojo/mojo_public.gyp

+++ b/mojo/mojo_public.gyp

@@ -239,6 +239,7 @@

{

+ # TODO(yzshen): crbug.com/617718 Consider moving this into blink.

# GN version: //mojo/public/cpp/bindings:wtf_support

'target_name': 'mojo_cpp_bindings_wtf_support',

'type': 'static_library',

@@ -262,11 +263,6 @@

'mojo_cpp_bindings',

'../third_party/WebKit/Source/config.gyp:config',

- 'direct_dependent_settings': {

- 'variables': {

- 'clang_warning_flags_unset': [ '-Wglobal-constructors' ],

- },

{

# GN version: //mojo/message_pump

« no previous file with comments | « mojo/mojo_edk_tests.gyp ('k') | mojo/public/cpp/bindings/BUILD.gn » ('j') | no next file with comments »