Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: mojo/mojo_edk_tests.gyp

Issue 2038413003: Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF type… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/mojo_public.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/mojo_edk_tests.gyp
diff --git a/mojo/mojo_edk_tests.gyp b/mojo/mojo_edk_tests.gyp
index bec747126888fbd997fc3533451bfc2c14405f93..c7b2edd18f619265508f6d50b28469639b7fe00a 100644
--- a/mojo/mojo_edk_tests.gyp
+++ b/mojo/mojo_edk_tests.gyp
@@ -41,6 +41,9 @@
'mojo_public.gyp:mojo_public_test_interfaces_struct_traits',
'mojo_public.gyp:mojo_public_test_utils',
],
+ 'variables': {
+ 'clang_warning_flags_unset': [ '-Wglobal-constructors' ],
+ },
'sources': [
'public/cpp/bindings/tests/array_common_test.h',
'public/cpp/bindings/tests/array_unittest.cc',
@@ -92,6 +95,9 @@
'public/cpp/bindings/tests/variant_test_util.h',
],
'conditions': [
+ # TODO(yzshen): Blink-flavor bindings tests should be moved into
+ # mojo_public_bindings_for_blink_tests (which should eventually be moved
+ # into blink).
['OS=="ios"', {
'dependencies!': [
'mojo_public.gyp:mojo_public_test_interfaces_blink',
@@ -120,6 +126,9 @@
'mojo_public.gyp:mojo_public_test_wtf_types',
'mojo_public.gyp:mojo_public_test_wtf_types_blink',
],
+ 'variables': {
+ 'clang_warning_flags_unset': [ '-Wglobal-constructors' ],
+ },
'sources': [
'public/cpp/bindings/tests/array_common_test.h',
'public/cpp/bindings/tests/container_test_util.cc',
« no previous file with comments | « no previous file | mojo/mojo_public.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698