test/cctest/interpreter/bytecode_expectations/CountOperators.golden - Issue 2038323002: [interpreter] Filter expression positions at source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/CountOperators.golden

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing

Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden ('k') | test/cctest/interpreter/bytecode_expectations/CreateArguments.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/CountOperators.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/CountOperators.golden b/test/cctest/interpreter/bytecode_expectations/CountOperators.golden

index 69be6ffd8ed6cf2ad5156c9d453c99bf8890d329..3f6696cc239c33f1e30924baff2466217b2b58e2 100644

--- a/test/cctest/interpreter/bytecode_expectations/CountOperators.golden

+++ b/test/cctest/interpreter/bytecode_expectations/CountOperators.golden

@@ -41,7 +41,7 @@ bytecodes: [

/* 45 S> */ B(ToNumber),

B(Star), R(1),

B(Inc),

- /* 53 E> */ B(Star), R(0),

+ B(Star), R(0),

B(Ldar), R(1),

/* 57 S> */ B(Return),

]

@@ -84,7 +84,7 @@ bytecodes: [

/* 45 S> */ B(ToNumber),

B(Star), R(1),

B(Dec),

- /* 53 E> */ B(Star), R(0),

+ B(Star), R(0),

B(Ldar), R(1),

/* 57 S> */ B(Return),

]

@@ -150,7 +150,7 @@ snippet: "

frame size: 5

parameter count: 1

-bytecode array length: 30

+bytecode array length: 29

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 45 S> */ B(LdaConstant), U8(0),

@@ -158,9 +158,8 @@ bytecodes: [

/* 60 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(1),

B(Star), R(2),

B(Star), R(1),

- /* 72 S> */ B(Nop),

- /* 81 E> */ B(Ldar), R(0),

- B(LdaKeyedProperty), R(1), U8(1),

+ /* 72 S> */ B(Ldar), R(0),

+ /* 81 E> */ B(LdaKeyedProperty), R(1), U8(1),

B(ToNumber),

B(Star), R(4),

B(Dec),

@@ -181,7 +180,7 @@ snippet: "

frame size: 3

parameter count: 1

-bytecode array length: 25

+bytecode array length: 24

bytecodes: [

/* 30 E> */ B(StackCheck),

/* 45 S> */ B(LdaConstant), U8(0),

@@ -189,9 +188,8 @@ bytecodes: [

/* 60 S> */ B(CreateObjectLiteral), U8(1), U8(0), U8(1),

B(Star), R(2),

B(Star), R(1),

- /* 72 S> */ B(Nop),

- /* 83 E> */ B(Ldar), R(0),

- B(LdaKeyedProperty), R(1), U8(1),

+ /* 72 S> */ B(Ldar), R(0),

+ /* 83 E> */ B(LdaKeyedProperty), R(1), U8(1),

B(Inc),

/* 87 E> */ B(StaKeyedPropertySloppy), R(1), R(0), U8(3),

/* 90 S> */ B(Return),

@@ -275,7 +273,7 @@ bytecodes: [

B(ToNumber),

B(Star), R(3),

B(Inc),

- /* 75 E> */ B(Star), R(0),

+ B(Star), R(0),

B(LdaSmi), U8(2),

/* 79 E> */ B(StaKeyedPropertySloppy), R(1), R(3), U8(1),

/* 84 S> */ B(Return),