test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden - Issue 2038323002: [interpreter] Filter expression positions at source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden

Issue 2038323002: [interpreter] Filter expression positions at source. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0060-source-position-testing

Patch Set: Fix expression positions on StackCheck that this CL broke. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-array-builder.h ('K') | « test/cctest/interpreter/bytecode_expectations/ConstVariable.golden ('k') | test/cctest/interpreter/bytecode_expectations/CountOperators.golden » ('j') | test/cctest/interpreter/test-source-positions.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden

diff --git a/test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden b/test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden

index 60871016b4c8097143e794c0f5e51f329e8827aa..1cfdea84e2d4c86cabfc8a96c8538f560ceb22f3 100644

--- a/test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden

+++ b/test/cctest/interpreter/bytecode_expectations/ConstVariableContextSlot.golden

@@ -80,8 +80,8 @@ bytecodes: [

B(Star), R(0),

/* 30 E> */ B(StackCheck),

/* 47 S> */ B(LdaSmi), U8(20),

- /* 47 E> */ B(Star), R(2),

- B(LdaContextSlot), R(context), U8(4),

+ B(Star), R(2),

+ /* 47 E> */ B(LdaContextSlot), R(context), U8(4),

B(JumpIfNotHole), U8(11),

B(LdaConstant), U8(1),

B(Star), R(3),

@@ -118,8 +118,8 @@ bytecodes: [

/* 44 S> */ B(LdaSmi), U8(10),

/* 44 E> */ B(StaContextSlot), R(context), U8(4),

/* 48 S> */ B(LdaSmi), U8(20),

- /* 50 E> */ B(Star), R(2),

- B(LdaContextSlot), R(context), U8(4),

+ B(Star), R(2),

+ /* 50 E> */ B(LdaContextSlot), R(context), U8(4),

B(JumpIfNotHole), U8(11),

B(LdaConstant), U8(1),

B(Star), R(3),