[interpreter] Filter expression positions at source.

src/interpreter/bytecode-array-builder.h

Index: src/interpreter/bytecode-array-builder.h
diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h
index 3cdea52aae08488f00109c26786080664407301e..907aa8661d1f9ec0e688d23120b5efe97dbdba18 100644
--- a/src/interpreter/bytecode-array-builder.h
+++ b/src/interpreter/bytecode-array-builder.h
@@ -315,6 +315,9 @@ class BytecodeArrayBuilder final : public ZoneObject {
                       int operand_index, uint32_t operand_value) const;
   bool RegisterIsValid(Register reg, OperandSize reg_size) const;
 
+  // Test if bytecode needs an expression position to be attached.
+  static bool NeedExpressionPosition(Bytecode bytecode);

[Yang, 2016/06/08 13:04:54]

I wonder whether that should belong in interpreter::Bytecodes. We have a bunch
of static functions like IsCallOrNew, IsBytecodeWithScalableOperands,
IsWithoutExternalSideEffects etc.

By that convention it would also be singular, i.e. NeedsExpressionPosition.

[oth, 2016/06/08 15:04:21]

Yes, it could do. The only quirk with this is that it depends on a v8 flag and
none of the other Bytecodes methods do so it's behaviour is not independent of
options.

I've tweaked to put it in a private namespace so it's no longer exposed. Happy
to put it in Bytecodes or leave as-is if anyone has a stronger opinion on this.

+
   // Attach latest source position to |node|.
   void AttachSourceInfo(BytecodeNode* node);