Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issue 2032613007: Change ImmutableStylePropertySet to store const CSSValue (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 6 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@+make_elementstyleresources_store_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ImmutableStylePropertySet to store const CSSValue Change ImmutableStylePropertySet to store const CSSValue instead of just CSSValue. This is pre-work for making CSSProperty store const CSSValues. BUG=526586 Committed: https://crrev.com/3836192c5a1bd83949c389157256739ea2cf1c59 Cr-Commit-Position: refs/heads/master@{#398002}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/StylePropertySet.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
sashab
4 years, 6 months ago (2016-06-03 08:26:18 UTC) #2
Timothy Loh
On 2016/06/03 08:26:18, sashab wrote: lgtm
4 years, 6 months ago (2016-06-06 02:55:10 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2038443003 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-06-06 05:47:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032613007/1
4 years, 6 months ago (2016-06-06 06:33:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 10:28:02 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 10:29:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3836192c5a1bd83949c389157256739ea2cf1c59
Cr-Commit-Position: refs/heads/master@{#398002}

Powered by Google App Engine
This is Rietveld 408576698