Fixing invalid visibility states with layers (opacity==0, visibility==true)

Fixing invalid visibility states with layers (opacity==0, visibility==true)

This addresses the failures of invalid state for some cases. Overview mode is not yet handled.

BUG=351553
TEST=visual, unit tests with activated DCHECK

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257870

[Mr4D (OOO till 08-26), 2014-03-18 18:31:40]

Please have a look!

[sky, 2014-03-18 20:13:10]

LGTM

https://codereview.chromium.org/203793004/diff/1/ash/wm/panels/panel_layout_m...
File ash/wm/panels/panel_layout_manager.cc (right):

https://codereview.chromium.org/203793004/diff/1/ash/wm/panels/panel_layout_m...
ash/wm/panels/panel_layout_manager.cc:877: // Show the window after we have
started the opacity animation.
I'll say it again, don't document what the code does, document why, eg:

// Show after changing the opacity, this way we don't have a state
// where the widget is visible but the opacity is 0.

[Mr4D (OOO till 08-26), 2014-03-18 21:32:05]

Thanks!

https://codereview.chromium.org/203793004/diff/1/ash/wm/panels/panel_layout_m...
File ash/wm/panels/panel_layout_manager.cc (right):

https://codereview.chromium.org/203793004/diff/1/ash/wm/panels/panel_layout_m...
ash/wm/panels/panel_layout_manager.cc:877: // Show the window after we have
started the opacity animation.
Done.

[Mr4D (OOO till 08-26), 2014-03-18 21:32:09]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-03-18 21:46:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/203793004/20001

[commit-bot: I haz the power, 2014-03-18 23:29:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/203793004/20001

[commit-bot: I haz the power, 2014-03-19 06:22:08]

Change committed as 257870