Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2233)

Unified Diff: ash/wm/system_modal_container_layout_manager.cc

Issue 203793004: Fixing invalid visibility states with layers (opacity==0, visibility==true) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changed comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/panels/panel_layout_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/system_modal_container_layout_manager.cc
diff --git a/ash/wm/system_modal_container_layout_manager.cc b/ash/wm/system_modal_container_layout_manager.cc
index faba106d863eaed627d13ad62fc8440a61badbba..a1432c6b9cfb3acfe3075d068d70895a725f87fa 100644
--- a/ash/wm/system_modal_container_layout_manager.cc
+++ b/ash/wm/system_modal_container_layout_manager.cc
@@ -165,8 +165,10 @@ void SystemModalContainerLayoutManager::CreateModalBackground() {
ui::ScopedLayerAnimationSettings settings(
modal_background_->GetNativeView()->layer()->GetAnimator());
- modal_background_->Show();
+ // Show should not be called with a target opacity of 0. We therefore start
+ // the fade to show animation before Show() is called.
modal_background_->GetNativeView()->layer()->SetOpacity(0.5f);
+ modal_background_->Show();
container_->StackChildAtTop(modal_background_->GetNativeView());
}
« no previous file with comments | « ash/wm/panels/panel_layout_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698