Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2037673002: [turbofan] Remove frame state input from speculative ops. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-5
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove frame state input from speculative ops. These speculative binary operators are simplified operators and should not need a frame state themselves. These eager bailout points can by now be found via checkpoints in the graph, whereas frame states attached to nodes directly should always represent lazy bailout points. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/28e6753acc9d4566145998596d5f05f1fc53c1d7 Cr-Commit-Position: refs/heads/master@{#36705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M src/compiler/js-typed-lowering.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/operator-properties.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 4 chunks +2 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-02 14:23:41 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-03 08:50:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037673002/1
4 years, 6 months ago (2016-06-03 09:42:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 10:00:26 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 10:02:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28e6753acc9d4566145998596d5f05f1fc53c1d7
Cr-Commit-Position: refs/heads/master@{#36705}

Powered by Google App Engine
This is Rietveld 408576698