[turbofan] Add frame state propagation to linearizer.

[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=jarin@chromium.org
BUG=v8:5021
Committed: https://crrev.com/10284b2948c40668d36fd03da65249daabec17e2
Cr-Commit-Position: refs/heads/master@{#36710}

[Michael Starzinger, 2016-06-02 16:29:02]

Description was changed from

==========
[turbofan] Add frame state propagation to linearizer.

This implements progagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=
BUG=v8:5021
==========

to

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=
BUG=v8:5021
==========

[Michael Starzinger, 2016-06-02 17:10:21]

Description was changed from

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=
BUG=v8:5021
==========

to

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=jarin@chromium.org
BUG=v8:5021
==========

[Michael Starzinger, 2016-06-02 17:10:21]

mstarzinger@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2016-06-03 09:20:01]

lgtm. Awesome!

https://codereview.chromium.org/2033143002/diff/20001/src/compiler/effect-con...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2033143002/diff/20001/src/compiler/effect-con...
src/compiler/effect-control-linearizer.cc:238: frame_state = nullptr;
As discussed offline, we will need to go hunting for a frame state once
deoptimizing nodes roam freely through the schedule.

[Michael Starzinger, 2016-06-03 09:52:05]

Thanks! Landing now-ish.

https://codereview.chromium.org/2033143002/diff/20001/src/compiler/effect-con...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2033143002/diff/20001/src/compiler/effect-con...
src/compiler/effect-control-linearizer.cc:238: frame_state = nullptr;
On 2016/06/03 09:20:01, Jarin wrote:
> As discussed offline, we will need to go hunting for a frame state once
> deoptimizing nodes roam freely through the schedule.

Acknowledged. Agreed. I added a TODO in that regard.

[Benedikt Meurer, 2016-06-03 10:53:09]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-06-03 10:53:10]

LGTM with nit.

https://codereview.chromium.org/2033143002/diff/40001/src/compiler/effect-con...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2033143002/diff/40001/src/compiler/effect-con...
src/compiler/effect-control-linearizer.cc:309: #ifdef DEBUG
Nit: Please no DEBUG.

[Michael Starzinger, 2016-06-03 10:59:08]

Thanks! Addressed comments. Landing.

https://codereview.chromium.org/2033143002/diff/40001/src/compiler/effect-con...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2033143002/diff/40001/src/compiler/effect-con...
src/compiler/effect-control-linearizer.cc:309: #ifdef DEBUG
On 2016/06/03 10:53:10, Benedikt Meurer wrote:
> Nit: Please no DEBUG.

Done.

[Michael Starzinger, 2016-06-03 11:21:10]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-06-03 11:21:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2033143002/#ps80001
(title: "Addressed comment.")

[commit-bot: I haz the power, 2016-06-03 11:21:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2033143002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2033143002/80001

[commit-bot: I haz the power, 2016-06-03 11:37:23]

Description was changed from

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=jarin@chromium.org
BUG=v8:5021
==========

to

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=jarin@chromium.org
BUG=v8:5021
==========

[commit-bot: I haz the power, 2016-06-03 11:37:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-03 11:39:40]

Description was changed from

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=jarin@chromium.org
BUG=v8:5021
==========

to

==========
[turbofan] Add frame state propagation to linearizer.

This implements propagation of frame states from checkpoints to all
deoptimization points inserted by the EffectControlLinearizer. It also
allows us to remove the eager frame state input from all the checked
conversion operations.

R=jarin@chromium.org
BUG=v8:5021

Committed: https://crrev.com/10284b2948c40668d36fd03da65249daabec17e2
Cr-Commit-Position: refs/heads/master@{#36710}
==========

[commit-bot: I haz the power, 2016-06-03 11:39:41]

Patchset 5 (id:??) landed as
https://crrev.com/10284b2948c40668d36fd03da65249daabec17e2
Cr-Commit-Position: refs/heads/master@{#36710}