Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2034673002: [turbofan] Remove eager frame state from property access. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-checkpoint-3
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove eager frame state from property access. This removes the frame state input representing the before-state from nodes performing property accesses. These frame states can by now be found via checkpoints in the graph. R=jarin@chromium.org BUG=v8:5021 Committed: https://crrev.com/bf7034bfed54b36caddae7a77e8decfff54f248e Cr-Commit-Position: refs/heads/master@{#36699}

Patch Set 1 #

Patch Set 2 : Fix checkpoint with empty frame state. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-native-context-specialization.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 2 2 chunks +10 lines, -7 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 2 7 chunks +17 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-02 12:47:10 UTC) #3
Jarin
lgtm
4 years, 6 months ago (2016-06-03 08:47:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034673002/40001
4 years, 6 months ago (2016-06-03 08:55:05 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-03 08:57:11 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 08:59:39 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf7034bfed54b36caddae7a77e8decfff54f248e
Cr-Commit-Position: refs/heads/master@{#36699}

Powered by Google App Engine
This is Rietveld 408576698