Empty SVG viewbox should be treated invalid

Empty SVG viewbox should be treated invalid

If SVG viewbox is explicitly empty, it should be
treated as invalid value.

BUG=608413
Committed: https://crrev.com/7d1027c45036b7da5389faa99e3b54209398a3c1
Cr-Commit-Position: refs/heads/master@{#397735}

[Shanmuga Pandi, 2016-06-02 08:49:26]

shanmuga.m@samsung.com changed reviewers:
+ rob.buis@samsung.com

[Shanmuga Pandi, 2016-06-02 08:49:27]

PTAL!!

Thanks

[rwlbuis, 2016-06-02 13:02:55]

On 2016/06/02 08:49:27, Shanmuga Pandi wrote:
> PTAL!!
> 
> Thanks

Peer looks good to me.

[Shanmuga Pandi, 2016-06-03 06:23:50]

shanmuga.m@samsung.com changed reviewers:
+ ed@chromium.org, fs@opera.com, pdr@google.com

[Shanmuga Pandi, 2016-06-03 06:23:50]

PTAL!!

Thanks

[pdr., 2016-06-03 06:34:55]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 06:35:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037573002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037573002/1

[commit-bot: I haz the power, 2016-06-03 08:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 08:23:18]

Dry run: This issue passed the CQ dry run.

[fs, 2016-06-03 08:58:03]

https://codereview.chromium.org/2037573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp (right):

https://codereview.chromium.org/2037573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp:53: if (value.isEmpty())
{
Should probably fix this down in SVGRect instead.

[Shanmuga Pandi, 2016-06-03 10:20:53]

https://codereview.chromium.org/2037573002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp (right):

https://codereview.chromium.org/2037573002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp:53: if (value.isEmpty())
{
On 2016/06/03 08:58:03, fs wrote:
> Should probably fix this down in SVGRect instead.

Done.

[fs, 2016-06-03 10:42:51]

https://codereview.chromium.org/2037573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGRect.cpp (right):

https://codereview.chromium.org/2037573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGRect.cpp:75: if (string.isNull() ||
string.isEmpty())
isEmpty() would be an error, so probably not return NoError.

(Probably rather SVGParsingError(SVGParseStatus::ExpectedNumber, 0) or so.)

[Shanmuga Pandi, 2016-06-03 13:09:31]

Please check now!!

https://codereview.chromium.org/2037573002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGRect.cpp (right):

https://codereview.chromium.org/2037573002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGRect.cpp:75: if (string.isNull() ||
string.isEmpty())
On 2016/06/03 10:42:51, fs wrote:
> isEmpty() would be an error, so probably not return NoError.
> 
> (Probably rather SVGParsingError(SVGParseStatus::ExpectedNumber, 0) or so.)

Done.

[fs, 2016-06-03 13:15:53]

lgtm

[Shanmuga Pandi, 2016-06-03 13:39:04]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-06-03 13:39:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037573002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037573002/40001

[commit-bot: I haz the power, 2016-06-03 17:12:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 17:15:13]

Description was changed from

==========
Empty SVG viewbox should be treated invalid

If SVG viewbox is explicitly empty, it should be
treated as invalid value.

BUG=608413
==========

to

==========
Empty SVG viewbox should be treated invalid

If SVG viewbox is explicitly empty, it should be
treated as invalid value.

BUG=608413

Committed: https://crrev.com/7d1027c45036b7da5389faa99e3b54209398a3c1
Cr-Commit-Position: refs/heads/master@{#397735}
==========

[commit-bot: I haz the power, 2016-06-03 17:15:14]

Patchset 3 (id:??) landed as
https://crrev.com/7d1027c45036b7da5389faa99e3b54209398a3c1
Cr-Commit-Position: refs/heads/master@{#397735}