Empty SVG viewbox should be treated invalid

third_party/WebKit/Source/core/svg/SVGFitToViewBox.cpp

 /*
  * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2010 Rob Buis <buis@kde.org>
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 31 matching lines @@
 
 protected:
     SVGAnimatedViewBoxRect(SVGElement* contextElement)
         : SVGAnimatedRect(contextElement, SVGNames::viewBoxAttr)
     {
     }
 };
 
 SVGParsingError SVGAnimatedViewBoxRect::setBaseValueAsString(const String& value)
 {
+    // Empty string should be treated as invalid viewBox
+    if (value.isEmpty()) {

[fs, 2016/06/03 08:58:03]

Should probably fix this down in SVGRect instead.

[Shanmuga Pandi, 2016/06/03 10:20:53]

Done.

+        baseValue()->setInvalid();
+        return SVGParseStatus::NoError;
+    }
+
     SVGParsingError parseStatus = SVGAnimatedRect::setBaseValueAsString(value);
 
     if (parseStatus == SVGParseStatus::NoError && (baseValue()->width() < 0 || baseValue()->height() < 0)) {
         parseStatus = SVGParseStatus::NegativeValue;
         baseValue()->setInvalid();
     }
     return parseStatus;
 }
 
 SVGFitToViewBox::SVGFitToViewBox(SVGElement* element, PropertyMapPolicy propertyMapPolicy)
@@ skipping 26 matching lines @@
     return attrName == SVGNames::viewBoxAttr || attrName == SVGNames::preserveAspectRatioAttr;
 }
 
 void SVGFitToViewBox::updateViewBox(const FloatRect& rect)
 {
     ASSERT(m_viewBox);
     m_viewBox->baseValue()->setValue(rect);
 }
 
 } // namespace blink