Empty SVG viewbox should be treated invalid

third_party/WebKit/Source/core/svg/SVGRect.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 54 matching lines @@
 
     m_value = FloatRect(x, y, width, height);
     m_isValid = true;
     return SVGParseStatus::NoError;
 }
 
 SVGParsingError SVGRect::setValueAsString(const String& string)
 {
     setInvalid();
 
-    if (string.isNull())
+    if (string.isNull() || string.isEmpty())

[fs, 2016/06/03 10:42:51]

isEmpty() would be an error, so probably not return NoError.

(Probably rather SVGParsingError(SVGParseStatus::ExpectedNumber, 0) or so.)

[Shanmuga Pandi, 2016/06/03 13:09:31]

Done.

         return SVGParseStatus::NoError;
 
-    if (string.isEmpty()) {
-        m_value = FloatRect(0.0f, 0.0f, 0.0f, 0.0f);
-        m_isValid = true;
-        return SVGParseStatus::NoError;
-    }
-
     if (string.is8Bit()) {
         const LChar* ptr = string.characters8();
         const LChar* end = ptr + string.length();
         return parse(ptr, end);
     }
     const UChar* ptr = string.characters16();
     const UChar* end = ptr + string.length();
     return parse(ptr, end);
 }
 
@@ skipping 40 matching lines @@
     return -1;
 }
 
 void SVGRect::setInvalid()
 {
     m_value = FloatRect(0.0f, 0.0f, 0.0f, 0.0f);
     m_isValid = false;
 }
 
 } // namespace blink