Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2037453003: [turbofan] Add new StringFromCharCode simplified operator. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add new StringFromCharCode simplified operator. We use StringFromCharCode to optimize calls to String.fromCharCode with a single Number argument for now. We will use it to also implement the charAt method on the String prototype. R=jarin@chromium.org Committed: https://crrev.com/5a3a6dafae9cebf036021bbf65cab58711e21fba Cr-Commit-Position: refs/heads/master@{#36668}

Patch Set 1 #

Patch Set 2 : Mitigate verifier blowup after early optimization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -5 lines) Patch
M src/code-stub-assembler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 3 chunks +130 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 2 chunks +35 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-02 07:08:26 UTC) #1
Benedikt Meurer
Hey Jaro, Initial support for String.fromCharCode in TurboFan. Please take a look. Thanks, Benedikt
4 years, 6 months ago (2016-06-02 07:15:53 UTC) #2
Jarin
lgtm
4 years, 6 months ago (2016-06-02 07:32:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037453003/20001
4 years, 6 months ago (2016-06-02 07:33:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 07:59:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 08:01:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5a3a6dafae9cebf036021bbf65cab58711e21fba
Cr-Commit-Position: refs/heads/master@{#36668}

Powered by Google App Engine
This is Rietveld 408576698