Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2032613006: [turbofan] Run EarlyOptimizationPhase after we nuked the types. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@StringFromCharCode
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run EarlyOptimizationPhase after we nuked the types. It's not safe to look at the types after SimplifiedLowering runs, as the types are unreliable by that time. So better make sure we nuke the types first. R=jarin@chromium.org Committed: https://crrev.com/fc881eb7a61260dfff25415d528b218117aae70e Cr-Commit-Position: refs/heads/master@{#36671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/compiler/pipeline.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-02 08:00:04 UTC) #1
Jarin
lgtm
4 years, 6 months ago (2016-06-02 08:01:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032613006/1
4 years, 6 months ago (2016-06-02 08:01:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/2566)
4 years, 6 months ago (2016-06-02 08:02:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2032613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2032613006/1
4 years, 6 months ago (2016-06-02 08:08:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-02 08:28:50 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 08:30:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc881eb7a61260dfff25415d528b218117aae70e
Cr-Commit-Position: refs/heads/master@{#36671}

Powered by Google App Engine
This is Rietveld 408576698