Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Side by Side Diff: src/compiler/verifier.cc

Issue 2037453003: [turbofan] Add new StringFromCharCode simplified operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mitigate verifier blowup after early optimization. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/js-builtin-reducer-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 743 matching lines...) Expand 10 before | Expand all | Expand 10 after
754 CheckUpperIs(node, Type::Boolean()); 754 CheckUpperIs(node, Type::Boolean());
755 break; 755 break;
756 case IrOpcode::kStringEqual: 756 case IrOpcode::kStringEqual:
757 case IrOpcode::kStringLessThan: 757 case IrOpcode::kStringLessThan:
758 case IrOpcode::kStringLessThanOrEqual: 758 case IrOpcode::kStringLessThanOrEqual:
759 // (String, String) -> Boolean 759 // (String, String) -> Boolean
760 CheckValueInputIs(node, 0, Type::String()); 760 CheckValueInputIs(node, 0, Type::String());
761 CheckValueInputIs(node, 1, Type::String()); 761 CheckValueInputIs(node, 1, Type::String());
762 CheckUpperIs(node, Type::Boolean()); 762 CheckUpperIs(node, Type::Boolean());
763 break; 763 break;
764 case IrOpcode::kStringFromCharCode:
765 // Number -> String
766 CheckValueInputIs(node, 0, Type::Number());
767 CheckUpperIs(node, Type::String());
768 break;
764 case IrOpcode::kStringToNumber: 769 case IrOpcode::kStringToNumber:
765 // String -> Number 770 // String -> Number
766 CheckValueInputIs(node, 0, Type::String()); 771 CheckValueInputIs(node, 0, Type::String());
767 CheckUpperIs(node, Type::Number()); 772 CheckUpperIs(node, Type::Number());
768 break; 773 break;
769 case IrOpcode::kReferenceEqual: { 774 case IrOpcode::kReferenceEqual: {
770 // (Unique, Any) -> Boolean and 775 // (Unique, Any) -> Boolean and
771 // (Any, Unique) -> Boolean 776 // (Any, Unique) -> Boolean
772 CheckUpperIs(node, Type::Boolean()); 777 CheckUpperIs(node, Type::Boolean());
773 break; 778 break;
(...skipping 619 matching lines...) Expand 10 before | Expand all | Expand 10 after
1393 replacement->op()->EffectOutputCount() > 0); 1398 replacement->op()->EffectOutputCount() > 0);
1394 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1399 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1395 replacement->opcode() == IrOpcode::kFrameState); 1400 replacement->opcode() == IrOpcode::kFrameState);
1396 } 1401 }
1397 1402
1398 #endif // DEBUG 1403 #endif // DEBUG
1399 1404
1400 } // namespace compiler 1405 } // namespace compiler
1401 } // namespace internal 1406 } // namespace internal
1402 } // namespace v8 1407 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/unittests/compiler/js-builtin-reducer-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698