Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 20370002: Remove some old support for PNaCl Scons browser tests. (Closed)

Created:
7 years, 5 months ago by jvoung (off chromium)
Modified:
7 years, 5 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

Remove some old support for PNaCl Scons browser tests. We no longer run scons nacl_integration tests w/ PNaCl. This allows us to get rid of $GENNMF from Scons and remove the unused pnacl-nmf.py driver script from the toolchain tarball. Devs can use create_nmf.py instead from the SDK. BUG=none R=mseaborn@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213719

Patch Set 1 #

Patch Set 2 : some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -68 lines) Patch
M ppapi/native_client/chrome_main.scons View 1 6 chunks +11 lines, -42 lines 0 comments Download
M ppapi/native_client/tests/breakpad_crash_test/nacl.scons View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html View 1 1 chunk +5 lines, -13 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/extension_mime_handler/nacl.scons View 1 1 chunk +0 lines, -5 lines 0 comments Download
M ppapi/native_client/tools/browser_tester/browser_tester.py View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/native_client/tools/browser_tester/browsertester/browserlauncher.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvoung (off chromium)
7 years, 5 months ago (2013-07-25 21:30:34 UTC) #1
Mark Seaborn
LGTM, thanks
7 years, 5 months ago (2013-07-25 21:36:54 UTC) #2
jvoung (off chromium)
7 years, 5 months ago (2013-07-25 23:22:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r213719 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698