Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html

Issue 20370002: Remove some old support for PNaCl Scons browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: some tests Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html
diff --git a/ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html b/ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html
index 509f437222ddb40d5176d25a8d372bcb7060f5b2..94b5d496a1ed1d80f9a18f470b7ebeb7e10805e3 100644
--- a/ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html
+++ b/ppapi/native_client/tests/breakpad_crash_test/trusted_crash_in_startup.html
@@ -41,19 +41,11 @@ tester.addAsyncTest('trusted_crash_during_startup', function(status) {
status.log('Received error: ' + error);
// This error occurs only because NACL_CRASH_TEST is set. We would
// not normally expect to get this error in the browser.
- // For PNaCl, the crash will occur while starting the compiler process.
- var test_args = getTestArguments({ 'is_pnacl': 'false' });
- if (test_args['is_pnacl'] != 'false') {
- var expected_error = ('NaCl module load failed: PnaclCoordinator: ' +
- 'Compile process could not be created');
- status.assert(begins_with(embed.lastError, expected_error));
- } else {
- var expected_error_prefix = 'NaCl module load failed: ServiceRuntime: ';
- var suffix1 = 'command channel creation failed';
- var suffix2 = 'failed to start';
- status.assert(error == expected_error_prefix + suffix1 ||
- error == expected_error_prefix + suffix2);
- }
+ var expected_error_prefix = 'NaCl module load failed: ServiceRuntime: ';
+ var suffix1 = 'command channel creation failed';
+ var suffix2 = 'failed to start';
+ status.assert(error == expected_error_prefix + suffix1 ||
+ error == expected_error_prefix + suffix2);
status.pass();
}), true);

Powered by Google App Engine
This is Rietveld 408576698