Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 2036973002: Correctly move permission bubbles after entering / exiting fullscreen. (Closed)

Created:
4 years, 6 months ago by benwells
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Correctly move permission bubbles after entering / exiting fullscreen. When full screen is entered or exited the position of the bubble arrow may need to be updated. This change updates the location, and ensures the bubble is repainted when the arrow location is updated. BUG=614928 Review-Url: https://codereview.chromium.org/2036503002 Cr-Commit-Position: refs/heads/master@{#397314} (cherry picked from commit 2c657c1722cfc92eb307341859a294ff64d6d40a) Committed: https://chromium.googlesource.com/chromium/src/+/71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/cocoa/info_bubble_view.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
benwells
4 years, 6 months ago (2016-06-03 06:03:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71b82bdb5e75cbe689883e2d39dcbc54e36f5ebe.

Powered by Google App Engine
This is Rietveld 408576698