Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2036503002: Correctly move permission bubbles after entering / exiting fullscreen. (Closed)

Created:
4 years, 6 months ago by benwells
Modified:
4 years, 6 months ago
Reviewers:
tapted
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly move permission bubbles after entering / exiting fullscreen. When full screen is entered or exited the position of the bubble arrow may need to be updated. This change updates the location, and ensures the bubble is repainted when the arrow location is updated. BUG=614928 Committed: https://crrev.com/2c657c1722cfc92eb307341859a294ff64d6d40a Cr-Commit-Position: refs/heads/master@{#397314}

Patch Set 1 #

Total comments: 3

Patch Set 2 : tapted feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/ui/cocoa/info_bubble_view.mm View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
benwells
fyi this would be to merge into 52 ... I could probably do it in ...
4 years, 6 months ago (2016-06-02 01:09:06 UTC) #2
tapted
https://codereview.chromium.org/2036503002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm (right): https://codereview.chromium.org/2036503002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm#newcode305 chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:305: [[self bubble] setArrowLocation:[self getExpectedArrowLocation]]; I think this should be ...
4 years, 6 months ago (2016-06-02 01:23:07 UTC) #3
benwells
https://codereview.chromium.org/2036503002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm (right): https://codereview.chromium.org/2036503002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm#newcode305 chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:305: [[self bubble] setArrowLocation:[self getExpectedArrowLocation]]; On 2016/06/02 01:23:07, tapted wrote: ...
4 years, 6 months ago (2016-06-02 01:55:51 UTC) #4
benwells
https://codereview.chromium.org/2036503002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm (right): https://codereview.chromium.org/2036503002/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm#newcode305 chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:305: [[self bubble] setArrowLocation:[self getExpectedArrowLocation]]; On 2016/06/02 01:55:51, benwells wrote: ...
4 years, 6 months ago (2016-06-02 05:26:03 UTC) #5
tapted
lgtm
4 years, 6 months ago (2016-06-02 05:39:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036503002/20001
4 years, 6 months ago (2016-06-02 05:54:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 06:33:15 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:34:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c657c1722cfc92eb307341859a294ff64d6d40a
Cr-Commit-Position: refs/heads/master@{#397314}

Powered by Google App Engine
This is Rietveld 408576698