chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm - Issue 2036973002: Correctly move permission bubbles after entering / exiting fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 2036973002: Correctly move permission bubbles after entering / exiting fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

index bfb30cb157431c46f1930e802294250622f6aa72..56badab36f5315982fb282a11e1377a13df03fe3 100644

--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

@@ -263,7 +263,7 @@ const NSSize kPermissionIconSize = {18, 18};

- (void)parentWindowDidResize:(NSNotification*)notification {

DCHECK(bridge_);

- [self setAnchorPoint:[self getExpectedAnchorPoint]];

+ [self updateAnchorPosition];

}

- (void)parentWindowDidMove:(NSNotification*)notification {

@@ -433,6 +433,7 @@ const NSSize kPermissionIconSize = {18, 18};

- (void)updateAnchorPosition {

[self setParentWindow:[self getExpectedParentWindow]];

[self setAnchorPoint:[self getExpectedAnchorPoint]];

+ [[self bubble] setArrowLocation:[self getExpectedArrowLocation]];

}

- (NSPoint)getExpectedAnchorPoint {

« no previous file with comments | « chrome/browser/ui/cocoa/info_bubble_view.mm ('k') | no next file » | no next file with comments »