Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2036803002: [WIP] Use Optional<SkColor> instead of int64 for colors in Manifest.

Created:
4 years, 6 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, jam, mlamouri+watch-manifest_chromium.org, mlamouri+watch-content_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP] Use Optional<SkColor> instead of int64 for colors in Manifest. This is not meant to land now because we would need to add a new IPC traits it would be better to simply wait for the Manifest IPC handling to move to Mojo (see https://crrev.com/1913043002). BUG=???

Patch Set 1 #

Patch Set 2 : update wo/ unittests and android #

Patch Set 3 : with unit tests #

Patch Set 4 : with unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -107 lines) Patch
M content/browser/manifest/manifest_manager_host.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M content/public/common/manifest.h View 1 2 3 chunks +8 lines, -16 lines 0 comments Download
M content/public/common/manifest.cc View 1 2 3 chunks +3 lines, -11 lines 0 comments Download
M content/renderer/manifest/manifest_parser.h View 1 2 2 chunks +12 lines, -10 lines 0 comments Download
M content/renderer/manifest/manifest_parser.cc View 1 2 chunks +6 lines, -11 lines 0 comments Download
M content/renderer/manifest/manifest_parser_unittest.cc View 1 2 31 chunks +42 lines, -50 lines 0 comments Download

Depends on Patchset:

Issue 2198673002 Patch 1

Messages

Total messages: 4 (4 generated)
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run
4 years, 3 months ago (2016-09-15 11:17:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2036803002/60001
4 years, 3 months ago (2016-09-15 11:17:21 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 3 months ago (2016-09-15 11:37:25 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 11:37:25 UTC) #4 
Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698