Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 2036803002: [WIP] Use Optional<SkColor> instead of int64 for colors in Manifest. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with unit tests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/public/common/manifest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index ea6557fa4e06f31faaf798462c6ea2973bc3644f..279908a83eb69995199eee73fb93999f33849ee4 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -141,15 +141,6 @@ void ManifestManagerHost::OnRequestManifestResponse(
0, Manifest::kMaxIPCStringLength),
related_application.id.is_null());
}
- // theme_color and background_color are 32 bit unsigned integers with 64 bit
- // integers simply being used to encode the occurence of an error. Therefore,
- // any value outside the range of a 32 bit integer is invalid.
- if (manifest.theme_color < std::numeric_limits<int32_t>::min() ||
- manifest.theme_color > std::numeric_limits<int32_t>::max())
- manifest.theme_color = Manifest::kInvalidOrMissingColor;
- if (manifest.background_color < std::numeric_limits<int32_t>::min() ||
- manifest.background_color > std::numeric_limits<int32_t>::max())
- manifest.background_color = Manifest::kInvalidOrMissingColor;
callback->Run(manifest_url, manifest);
callbacks->Remove(request_id);
« no previous file with comments | « no previous file | content/public/common/manifest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698