Issue 2198673002: Implement Optional::has_value() and Optional::reset().

Issue 2198673002: Implement Optional::has_value() and Optional::reset(). (Closed)

Created:
4 years, 4 months ago by mlamouri (slow - plz ping)

Modified:
4 years, 4 months ago

Reviewers:
danakj

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Implement Optional::has_value() and Optional::reset(). BUG=632970 Committed: https://crrev.com/26204579039ff5d59d3c3a2cfde3e0b5cf9f96b5 Cr-Commit-Position: refs/heads/master@{#411026}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	base/optional.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	base/optional_unittest.cc	View		1 chunk	+45 lines, -0 lines	0 comments	Download

Dependent Patchsets:

Total messages: 13 (7 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2198673002/1

4 years, 4 months ago (2016-08-10 09:28:47 UTC) #10

commit-bot: I haz the power

4 years, 4 months ago (2016-08-10 12:26:44 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/26204579039ff5d59d3c3a2cfde3e0b5cf9f96b5
Cr-Commit-Position: refs/heads/master@{#411026}