Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2036593002: Add GetNoTxn to txnBuf as a hack. (Closed)

Created:
4 years, 6 months ago by iannucci
Modified:
4 years, 6 months ago
Reviewers:
dnj, dnj (Google), nodir
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add GetNoTxn to txnBuf as a hack. I really don't like this but short of fixing #23, I don't think there's much we can do. R=dnj@chromium.org, nodir@chromium.org BUG= Committed: https://github.com/luci/gae/commit/5787dea3cf12f40b4fc210c724dea92c7f5ff2bf

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M filter/txnBuf/context.go View 1 1 chunk +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
iannucci
4 years, 6 months ago (2016-06-02 00:40:00 UTC) #1
dnj (Google)
lgtm w/ nit https://codereview.chromium.org/2036593002/diff/1/filter/txnBuf/context.go File filter/txnBuf/context.go (right): https://codereview.chromium.org/2036593002/diff/1/filter/txnBuf/context.go#newcode51 filter/txnBuf/context.go:51: // currently buffered transaction, but it ...
4 years, 6 months ago (2016-06-02 04:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2036593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2036593002/20001
4 years, 6 months ago (2016-06-02 22:32:10 UTC) #6
iannucci
https://chromiumcodereview.appspot.com/2036593002/diff/1/filter/txnBuf/context.go File filter/txnBuf/context.go (right): https://chromiumcodereview.appspot.com/2036593002/diff/1/filter/txnBuf/context.go#newcode51 filter/txnBuf/context.go:51: // currently buffered transaction, but it also does not ...
4 years, 6 months ago (2016-06-02 22:32:21 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 22:35:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/5787dea3cf12f40b4fc210c724dea92c7f5ff2bf

Powered by Google App Engine
This is Rietveld 408576698