Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Side by Side Diff: filter/txnBuf/context.go

Issue 2036593002: Add GetNoTxn to txnBuf as a hack. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/gae@master
Patch Set: fix nit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The LUCI Authors. All rights reserved. 1 // Copyright 2015 The LUCI Authors. All rights reserved.
2 // Use of this source code is governed under the Apache License, Version 2.0 2 // Use of this source code is governed under the Apache License, Version 2.0
3 // that can be found in the LICENSE file. 3 // that can be found in the LICENSE file.
4 4
5 package txnBuf 5 package txnBuf
6 6
7 import ( 7 import (
8 "golang.org/x/net/context" 8 "golang.org/x/net/context"
9 9
10 ds "github.com/luci/gae/service/datastore" 10 ds "github.com/luci/gae/service/datastore"
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 } 39 }
40 40
41 // memoryCorruption is a marker function to indicate that given error is 41 // memoryCorruption is a marker function to indicate that given error is
42 // actually due to corrupted memory to make it easier to read the code. 42 // actually due to corrupted memory to make it easier to read the code.
43 func memoryCorruption(err error) { 43 func memoryCorruption(err error) {
44 if err != nil { 44 if err != nil {
45 panic(err) 45 panic(err)
46 } 46 }
47 } 47 }
48
49 // GetNoTxn allows you to to escape the buffered transaction (if any), and get
50 // a non-transactional handle to the datastore. This does not invalidate the
51 // currently-buffered transaction, but it also does not see any effects of it.
52 //
53 // TODO(iannucci): This is messy, but mostly because the way that transactions
54 // work is messy. Fixing luci/gae#issues/23 would help though, because it means
55 // we could make transactionality recorded by a single index in the context
56 // instead of relying on function nesting.
57 func GetNoTxn(c context.Context) ds.Interface {
58 c = context.WithValue(c, dsTxnBufParent, nil)
59 c = context.WithValue(c, dsTxnBufHaveLock, nil)
60 return ds.GetNoTxn(c)
61 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698