Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2028423002: Add DefaultVersionHostname to impl/memory/info. (Closed)

Created:
4 years, 6 months ago by iannucci
Modified:
4 years, 6 months ago
Reviewers:
dnj, dnj (Google), nodir
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@getnotxn
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : example.com #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M impl/memory/info.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
iannucci
4 years, 6 months ago (2016-06-02 00:40:15 UTC) #1
dnj (Google)
https://codereview.chromium.org/2028423002/diff/1/impl/memory/info.go File impl/memory/info.go (right): https://codereview.chromium.org/2028423002/diff/1/impl/memory/info.go#newcode110 impl/memory/info.go:110: return fmt.Sprintf("%s.appspot.com", gi.appID) WDYT about using "example.com"-style domain here? ...
4 years, 6 months ago (2016-06-02 04:07:11 UTC) #3
iannucci
ptal https://chromiumcodereview.appspot.com/2028423002/diff/1/impl/memory/info.go File impl/memory/info.go (right): https://chromiumcodereview.appspot.com/2028423002/diff/1/impl/memory/info.go#newcode110 impl/memory/info.go:110: return fmt.Sprintf("%s.appspot.com", gi.appID) On 2016/06/02 04:07:11, dnj (Google) ...
4 years, 6 months ago (2016-06-02 22:34:58 UTC) #4
dnj
lgtm
4 years, 6 months ago (2016-06-06 14:11:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2028423002/20001
4 years, 6 months ago (2016-06-11 02:19:29 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-11 02:24:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/5f6e967be7e9893bd683f7deb1fa317d1dd462f0

Powered by Google App Engine
This is Rietveld 408576698