third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 72f56e201201adc4ee3b647d722e5ba41db59d49..9d575c4386acf63e08442f360c3ffdedc0667f60 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -130,8 +130,8 @@ public:

void didPaint(const PaintArtifact&) override;

- void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) override;

- void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame* localRoot) override;

+ void attachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame*) override;

+ void detachCompositorAnimationTimeline(CompositorAnimationTimeline*, LocalFrame*) override;

void enterFullScreenForElement(Element*) override;

void exitFullScreenForElement(Element*) override;

« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | third_party/WebKit/Source/web/WebViewImpl.h » ('J')