Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 70905512f151dc17ad4376ec6ec27677327c4487..ba7ee97b4f0bc1304988b1692f97ff7aeb1affe0 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -425,11 +425,8 @@ public:
}
GraphicsLayer* rootGraphicsLayer();
- void setRootGraphicsLayer(GraphicsLayer*);
PaintLayerCompositor* compositor() const;
void scheduleAnimation();
- void attachCompositorAnimationTimeline(CompositorAnimationTimeline*);
- void detachCompositorAnimationTimeline(CompositorAnimationTimeline*);
CompositorAnimationTimeline* linkHighlightsTimeline() const { return m_linkHighlightsTimeline.get(); }
WebViewScheduler* scheduler() const override;
@@ -542,6 +539,7 @@ private:
friend class WebView; // So WebView::Create can call our constructor
friend class WTF::RefCounted<WebViewImpl>;
friend void setCurrentInputEventForTest(const WebInputEvent*);
+ friend class WebViewFrameWidget;
Mostyn Bramley-Moore 2016/07/05 15:33:27 This is a duplicate, after https://codereview.chro
enum DragAction {
DragEnter,
@@ -617,6 +615,10 @@ private:
float deviceScaleFactor() const;
+ void setRootGraphicsLayer(GraphicsLayer*);
+ void attachCompositorAnimationTimeline(CompositorAnimationTimeline*);
+ void detachCompositorAnimationTimeline(CompositorAnimationTimeline*);
+
WebViewClient* m_client; // Can be 0 (e.g. unittests, shared workers, etc.)
WebSpellCheckClient* m_spellCheckClient;
« no previous file with comments | « third_party/WebKit/Source/web/WebViewFrameWidget.cpp ('k') | third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698