content/renderer/render_frame_impl.cc - Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2036403002: Always use the WebFrameWidget when attaching the root graphics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | third_party/WebKit/Source/web/WebViewImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 4167222969def20c760b86eb6e739add6fd9986a..215b9a84ca5e75d31e54d2ab0ca6f5fa846ed003 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -2847,7 +2847,8 @@ void RenderFrameImpl::didChangeOpener(blink::WebFrame* opener) {

Send(new FrameHostMsg_DidChangeOpener(routing_id_, opener_routing_id));

}

-void RenderFrameImpl::frameDetached(blink::WebFrame* frame, DetachType type) {

+void RenderFrameImpl::frameDetached(blink::WebLocalFrame* frame,

+ DetachType type) {

// NOTE: This function is called on the frame that is being detached and not

// the parent frame. This is different from createChildFrame() which is

// called on the parent frame.

« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.h » ('j') | third_party/WebKit/Source/web/WebViewImpl.h » ('J')