Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 203603006: DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f… (Closed)

Created:
6 years, 9 months ago by vsevik
Modified:
6 years, 9 months ago
Reviewers:
lushnikov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods from View. R=lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169632

Patch Set 1 #

Patch Set 2 : Alphabetical #

Patch Set 3 : Rebaselined #

Patch Set 4 : Rebaselined #

Patch Set 5 : Rebaselined #

Patch Set 6 : Rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -99 lines) Patch
M Source/devtools/front_end/Dialog.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/GoToLineDialog.js View 3 chunks +12 lines, -11 lines 0 comments Download
M Source/devtools/front_end/NetworkItemView.js View 2 chunks +11 lines, -18 lines 0 comments Download
M Source/devtools/front_end/NetworkPanel.js View 1 2 3 4 chunks +15 lines, -11 lines 0 comments Download
M Source/devtools/front_end/ResourcesPanel.js View 4 chunks +26 lines, -7 lines 0 comments Download
M Source/devtools/front_end/SourceFrame.js View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/devtools/front_end/TabbedPane.js View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/devtools/front_end/View.js View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
vsevik
PTAL
6 years, 9 months ago (2014-03-19 10:05:55 UTC) #1
lushnikov
lgtm
6 years, 9 months ago (2014-03-19 11:57:25 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-19 15:47:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/203603006/40001
6 years, 9 months ago (2014-03-19 15:47:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 15:50:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 15:50:32 UTC) #6
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-19 15:58:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/203603006/60001
6 years, 9 months ago (2014-03-19 15:59:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 16:02:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-19 16:02:49 UTC) #10
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 9 months ago (2014-03-20 06:37:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/203603006/100001
6 years, 9 months ago (2014-03-20 06:37:22 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 07:41:58 UTC) #13
Message was sent while issue was closed. 
Change committed as 169632

Powered by Google App Engine
This is Rietveld 408576698