Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Source/devtools/front_end/NetworkPanel.js

Issue 203603006: DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/NetworkItemView.js ('k') | Source/devtools/front_end/ResourcesPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/NetworkPanel.js
diff --git a/Source/devtools/front_end/NetworkPanel.js b/Source/devtools/front_end/NetworkPanel.js
index 6b06a3bbf01c3525a6c7a762fa787488ae40436e..f7946ee378d121a22e5344510ad4f69e0f090f52 100644
--- a/Source/devtools/front_end/NetworkPanel.js
+++ b/Source/devtools/front_end/NetworkPanel.js
@@ -1736,12 +1736,13 @@ WebInspector.NetworkPanel = function()
/**
* @this {WebInspector.NetworkPanel}
+ * @return {?WebInspector.SourceFrame}
*/
- function viewGetter()
+ function sourceFrameGetter()
{
- return this.visibleView;
+ return this._networkItemView.currentSourceFrame();
}
- WebInspector.GoToLineDialog.install(this, viewGetter.bind(this));
+ WebInspector.GoToLineDialog.install(this, sourceFrameGetter.bind(this));
}
/** @enum {string} */
@@ -1847,6 +1848,9 @@ WebInspector.NetworkPanel.prototype = {
this._showRequest(event.data);
},
+ /**
+ * @param {?WebInspector.NetworkRequest} request
+ */
_showRequest: function(request)
{
if (!request)
@@ -1854,23 +1858,23 @@ WebInspector.NetworkPanel.prototype = {
this._toggleViewingRequestMode();
- if (this.visibleView) {
- this.visibleView.detach();
- delete this.visibleView;
+ if (this._networkItemView) {
+ this._networkItemView.detach();
+ delete this._networkItemView;
}
var view = new WebInspector.NetworkItemView(request);
view.show(this._viewsContainerElement);
- this.visibleView = view;
+ this._networkItemView = view;
},
_closeVisibleRequest: function()
{
this.element.classList.remove("viewing-resource");
- if (this.visibleView) {
- this.visibleView.detach();
- delete this.visibleView;
+ if (this._networkItemView) {
+ this._networkItemView.detach();
+ delete this._networkItemView;
}
},
@@ -1966,7 +1970,7 @@ WebInspector.NetworkPanel.prototype = {
if (!(target instanceof WebInspector.NetworkRequest))
return;
var request = /** @type {!WebInspector.NetworkRequest} */ (target);
- if (this.visibleView && this.visibleView.isShowing() && this.visibleView.request() === request)
+ if (this._networkItemView && this._networkItemView.isShowing() && this._networkItemView.request() === request)
return;
appendRevealItem.call(this, request);
« no previous file with comments | « Source/devtools/front_end/NetworkItemView.js ('k') | Source/devtools/front_end/ResourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698