Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: Source/devtools/front_end/NetworkItemView.js

Issue 203603006: DevTools: Make GoToLineDialog work based on sourceFrame and remove (can)highlightPosition methods f… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaselined Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/GoToLineDialog.js ('k') | Source/devtools/front_end/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/NetworkItemView.js
diff --git a/Source/devtools/front_end/NetworkItemView.js b/Source/devtools/front_end/NetworkItemView.js
index 2b4f9b520e381cf3b28342becfcb3ef8af698994..7b63bfb0320271ec38787f31a0adb90ebd415c32 100644
--- a/Source/devtools/front_end/NetworkItemView.js
+++ b/Source/devtools/front_end/NetworkItemView.js
@@ -73,6 +73,17 @@ WebInspector.NetworkItemView.prototype = {
},
/**
+ * @return {?WebInspector.SourceFrame}
+ */
+ currentSourceFrame: function()
+ {
+ var view = this.visibleView;
+ if (view && view instanceof WebInspector.SourceFrame)
+ return /** @type {!WebInspector.SourceFrame} */ (view);
+ return null;
+ },
+
+ /**
* @param {string=} tabId
*/
_selectTab: function(tabId)
@@ -173,23 +184,5 @@ WebInspector.RequestContentView.prototype = {
// Should be implemented by subclasses.
},
- /**
- * @override
- * @return {boolean}
- */
- canHighlightPosition: function()
- {
- return this._innerView && this._innerView.canHighlightPosition();
- },
-
- /**
- * @override
- */
- highlightPosition: function(line, column)
- {
- if (this.canHighlightPosition())
- this._innerView.highlightPosition(line, column);
- },
-
__proto__: WebInspector.RequestView.prototype
}
« no previous file with comments | « Source/devtools/front_end/GoToLineDialog.js ('k') | Source/devtools/front_end/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698