Prevent use of GPU IDC in Resourceless Software Draw

Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2af3e47380eb2a2a4ebb3b22c654b1881c722ccc
Cr-Commit-Position: refs/heads/master@{#397547}

[ericrk, 2016-06-02 19:48:48]

Description was changed from

==========
Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
==========

to

==========
Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ericrk, 2016-06-02 19:52:55]

ericrk@chromium.org changed reviewers:
+ vmpstr@chromium.org

[ericrk, 2016-06-02 19:52:56]

What do you think about something like this? Didn't want to add the param to
RendererSettings as then all renderers would have to deal with it (and this is
really a SW renderer issue).

[vmpstr, 2016-06-02 19:57:47]

lgtm

https://codereview.chromium.org/2035913002/diff/20001/cc/output/software_rend...
File cc/output/software_renderer.h (right):

https://codereview.chromium.org/2035913002/diff/20001/cc/output/software_rend...
cc/output/software_renderer.h:119: const bool use_image_hijack_canvas_;
Can you add a comment here explaining what this does.

https://codereview.chromium.org/2035913002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2035913002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:1694: output_surface_, NULL,
nit: nullptr while here.

[boliu, 2016-06-02 20:21:11]

verified fix with repro steps in crbug.com/613546

[ericrk, 2016-06-02 20:44:10]

Patchset #3 (id:40001) has been deleted

[ericrk, 2016-06-02 20:45:36]

thanks!

https://codereview.chromium.org/2035913002/diff/20001/cc/output/software_rend...
File cc/output/software_renderer.h (right):

https://codereview.chromium.org/2035913002/diff/20001/cc/output/software_rend...
cc/output/software_renderer.h:119: const bool use_image_hijack_canvas_;
On 2016/06/02 19:57:47, vmpstr wrote:
> Can you add a comment here explaining what this does. 

Done.

https://codereview.chromium.org/2035913002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/2035913002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_impl.cc:1694: output_surface_, NULL,
On 2016/06/02 19:57:47, vmpstr wrote:
> nit: nullptr while here.

Done.

[ericrk, 2016-06-02 20:45:41]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-06-02 20:45:41]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2035913002/#ps60001
(title: "feedback")

[commit-bot: I haz the power, 2016-06-02 20:47:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035913002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035913002/60001

[commit-bot: I haz the power, 2016-06-02 23:56:24]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-06-02 23:58:56]

Description was changed from

==========
Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Prevent use of GPU IDC in Resourceless Software Draw

An ImageDecodeController is created once for the lifetime of a Layer tree
host impl (LTHI). Normally this is fine, as a SW ImageDecodeController
(IDC) is created for SW raster and a GPU IDC is created for GPU raster.
However, when a GPU Raster LTHI temporarily goes into a resourceless
software draw, we may incorrectly use the GPU IDC during SW raster,
leading to crashes.

This change Adds a parameter to SoftwareRenderer,
|use_image_hijack_canvas|, which indicates whether or not the renderer
should use the ImageHijackCanvas and IDC. When we are using a GPU
enabled LayerTreeHostImpl for resourceless software draw, we set this
value to false.

BUG=614773
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/2af3e47380eb2a2a4ebb3b22c654b1881c722ccc
Cr-Commit-Position: refs/heads/master@{#397547}
==========

[commit-bot: I haz the power, 2016-06-02 23:58:56]

Patchset 3 (id:??) landed as
https://crrev.com/2af3e47380eb2a2a4ebb3b22c654b1881c722ccc
Cr-Commit-Position: refs/heads/master@{#397547}