Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: cc/output/software_renderer.h

Issue 2035913002: Prevent use of GPU IDC in Resourceless Software Draw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | cc/output/software_renderer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_OUTPUT_SOFTWARE_RENDERER_H_ 5 #ifndef CC_OUTPUT_SOFTWARE_RENDERER_H_
6 #define CC_OUTPUT_SOFTWARE_RENDERER_H_ 6 #define CC_OUTPUT_SOFTWARE_RENDERER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "cc/base/cc_export.h" 9 #include "cc/base/cc_export.h"
10 #include "cc/output/compositor_frame.h" 10 #include "cc/output/compositor_frame.h"
(...skipping 12 matching lines...) Expand all
23 class SolidColorDrawQuad; 23 class SolidColorDrawQuad;
24 class TextureDrawQuad; 24 class TextureDrawQuad;
25 class TileDrawQuad; 25 class TileDrawQuad;
26 26
27 class CC_EXPORT SoftwareRenderer : public DirectRenderer { 27 class CC_EXPORT SoftwareRenderer : public DirectRenderer {
28 public: 28 public:
29 static std::unique_ptr<SoftwareRenderer> Create( 29 static std::unique_ptr<SoftwareRenderer> Create(
30 RendererClient* client, 30 RendererClient* client,
31 const RendererSettings* settings, 31 const RendererSettings* settings,
32 OutputSurface* output_surface, 32 OutputSurface* output_surface,
33 ResourceProvider* resource_provider); 33 ResourceProvider* resource_provider,
34 bool use_image_hijack_canvas);
34 35
35 ~SoftwareRenderer() override; 36 ~SoftwareRenderer() override;
36 const RendererCapabilitiesImpl& Capabilities() const override; 37 const RendererCapabilitiesImpl& Capabilities() const override;
37 void Finish() override; 38 void Finish() override;
38 void SwapBuffers(const CompositorFrameMetadata& metadata) override; 39 void SwapBuffers(const CompositorFrameMetadata& metadata) override;
39 void DiscardBackbuffer() override; 40 void DiscardBackbuffer() override;
40 void EnsureBackbuffer() override; 41 void EnsureBackbuffer() override;
41 42
42 protected: 43 protected:
43 void BindFramebufferToOutputSurface(DrawingFrame* frame) override; 44 void BindFramebufferToOutputSurface(DrawingFrame* frame) override;
(...skipping 12 matching lines...) Expand all
56 bool FlippedFramebuffer(const DrawingFrame* frame) const override; 57 bool FlippedFramebuffer(const DrawingFrame* frame) const override;
57 void EnsureScissorTestEnabled() override; 58 void EnsureScissorTestEnabled() override;
58 void EnsureScissorTestDisabled() override; 59 void EnsureScissorTestDisabled() override;
59 void CopyCurrentRenderPassToBitmap( 60 void CopyCurrentRenderPassToBitmap(
60 DrawingFrame* frame, 61 DrawingFrame* frame,
61 std::unique_ptr<CopyOutputRequest> request) override; 62 std::unique_ptr<CopyOutputRequest> request) override;
62 63
63 SoftwareRenderer(RendererClient* client, 64 SoftwareRenderer(RendererClient* client,
64 const RendererSettings* settings, 65 const RendererSettings* settings,
65 OutputSurface* output_surface, 66 OutputSurface* output_surface,
66 ResourceProvider* resource_provider); 67 ResourceProvider* resource_provider,
68 bool use_image_hijack_canvas);
67 69
68 void DidChangeVisibility() override; 70 void DidChangeVisibility() override;
69 71
70 private: 72 private:
71 void ClearCanvas(SkColor color); 73 void ClearCanvas(SkColor color);
72 void ClearFramebuffer(DrawingFrame* frame); 74 void ClearFramebuffer(DrawingFrame* frame);
73 void SetClipRect(const gfx::Rect& rect); 75 void SetClipRect(const gfx::Rect& rect);
74 bool IsSoftwareResource(ResourceId resource_id) const; 76 bool IsSoftwareResource(ResourceId resource_id) const;
75 77
76 void DrawDebugBorderQuad(const DrawingFrame* frame, 78 void DrawDebugBorderQuad(const DrawingFrame* frame,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 gfx::Rect scissor_rect_; 110 gfx::Rect scissor_rect_;
109 111
110 SoftwareOutputDevice* output_device_; 112 SoftwareOutputDevice* output_device_;
111 SkCanvas* root_canvas_; 113 SkCanvas* root_canvas_;
112 SkCanvas* current_canvas_; 114 SkCanvas* current_canvas_;
113 SkPaint current_paint_; 115 SkPaint current_paint_;
114 std::unique_ptr<ResourceProvider::ScopedWriteLockSoftware> 116 std::unique_ptr<ResourceProvider::ScopedWriteLockSoftware>
115 current_framebuffer_lock_; 117 current_framebuffer_lock_;
116 sk_sp<SkCanvas> current_framebuffer_canvas_; 118 sk_sp<SkCanvas> current_framebuffer_canvas_;
117 119
120 // Indicates whether content rasterization should happen through an
121 // ImageHijackCanvas, which causes image decodes to be managed by an
122 // ImageDecodeController. We set this to false during resourceless software
123 // draw when a GPU ImageDecodeController is in use, as software rasterization
124 // cannot use the GPU IDC.
125 const bool use_image_hijack_canvas_;
126
118 DISALLOW_COPY_AND_ASSIGN(SoftwareRenderer); 127 DISALLOW_COPY_AND_ASSIGN(SoftwareRenderer);
119 }; 128 };
120 129
121 } // namespace cc 130 } // namespace cc
122 131
123 #endif // CC_OUTPUT_SOFTWARE_RENDERER_H_ 132 #endif // CC_OUTPUT_SOFTWARE_RENDERER_H_
OLDNEW
« no previous file with comments | « no previous file | cc/output/software_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698