Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1940)

Unified Diff: cc/output/software_renderer.h

Issue 2035913002: Prevent use of GPU IDC in Resourceless Software Draw (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/output/software_renderer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/software_renderer.h
diff --git a/cc/output/software_renderer.h b/cc/output/software_renderer.h
index f4733c5730c0fccb28ec644fd02d7fad009b5958..9323358d8cefb4717099e56cfaf00ed8f6363bcd 100644
--- a/cc/output/software_renderer.h
+++ b/cc/output/software_renderer.h
@@ -30,7 +30,8 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer {
RendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
- ResourceProvider* resource_provider);
+ ResourceProvider* resource_provider,
+ bool use_image_hijack_canvas);
~SoftwareRenderer() override;
const RendererCapabilitiesImpl& Capabilities() const override;
@@ -63,7 +64,8 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer {
SoftwareRenderer(RendererClient* client,
const RendererSettings* settings,
OutputSurface* output_surface,
- ResourceProvider* resource_provider);
+ ResourceProvider* resource_provider,
+ bool use_image_hijack_canvas);
void DidChangeVisibility() override;
@@ -115,6 +117,13 @@ class CC_EXPORT SoftwareRenderer : public DirectRenderer {
current_framebuffer_lock_;
sk_sp<SkCanvas> current_framebuffer_canvas_;
+ // Indicates whether content rasterization should happen through an
+ // ImageHijackCanvas, which causes image decodes to be managed by an
+ // ImageDecodeController. We set this to false during resourceless software
+ // draw when a GPU ImageDecodeController is in use, as software rasterization
+ // cannot use the GPU IDC.
+ const bool use_image_hijack_canvas_;
+
DISALLOW_COPY_AND_ASSIGN(SoftwareRenderer);
};
« no previous file with comments | « no previous file | cc/output/software_renderer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698