Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/compiler/verifier.cc

Issue 2035893004: [turbofan] Introduce a dedicated CheckBounds operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/regress-5100.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 906 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 case IrOpcode::kTruncateTaggedToWord32: { 917 case IrOpcode::kTruncateTaggedToWord32: {
918 // Number /\ Tagged -> Signed32 /\ UntaggedInt32 918 // Number /\ Tagged -> Signed32 /\ UntaggedInt32
919 // TODO(neis): Activate once ChangeRepresentation works in typer. 919 // TODO(neis): Activate once ChangeRepresentation works in typer.
920 // Type* from = Type::Intersect(Type::Number(), Type::Tagged()); 920 // Type* from = Type::Intersect(Type::Number(), Type::Tagged());
921 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32()); 921 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32());
922 // CheckValueInputIs(node, 0, from)); 922 // CheckValueInputIs(node, 0, from));
923 // CheckUpperIs(node, to)); 923 // CheckUpperIs(node, to));
924 break; 924 break;
925 } 925 }
926 926
927 case IrOpcode::kCheckBounds:
928 CheckValueInputIs(node, 0, Type::Any());
929 CheckValueInputIs(node, 1, Type::Unsigned31());
930 CheckUpperIs(node, Type::Unsigned31());
931 break;
932
927 case IrOpcode::kCheckedUint32ToInt32: 933 case IrOpcode::kCheckedUint32ToInt32:
928 case IrOpcode::kCheckedFloat64ToInt32: 934 case IrOpcode::kCheckedFloat64ToInt32:
929 case IrOpcode::kCheckedTaggedToInt32: 935 case IrOpcode::kCheckedTaggedToInt32:
930 case IrOpcode::kCheckedTaggedToFloat64: 936 case IrOpcode::kCheckedTaggedToFloat64:
931 break; 937 break;
932 938
933 case IrOpcode::kCheckFloat64Hole: 939 case IrOpcode::kCheckFloat64Hole:
934 CheckValueInputIs(node, 0, Type::Number()); 940 CheckValueInputIs(node, 0, Type::Number());
935 CheckUpperIs(node, Type::Number()); 941 CheckUpperIs(node, Type::Number());
936 break; 942 break;
(...skipping 508 matching lines...) Expand 10 before | Expand all | Expand 10 after
1445 replacement->op()->EffectOutputCount() > 0); 1451 replacement->op()->EffectOutputCount() > 0);
1446 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1452 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1447 replacement->opcode() == IrOpcode::kFrameState); 1453 replacement->opcode() == IrOpcode::kFrameState);
1448 } 1454 }
1449 1455
1450 #endif // DEBUG 1456 #endif // DEBUG
1451 1457
1452 } // namespace compiler 1458 } // namespace compiler
1453 } // namespace internal 1459 } // namespace internal
1454 } // namespace v8 1460 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/mjsunit/compiler/regress-5100.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698