cc: Add mask and replica layer ids to the effect tree

cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
Committed: https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5
Cr-Commit-Position: refs/heads/master@{#399690}

[ajuma, 2016-06-02 23:54:50]

Description was changed from

==========
WIP: cc: Put mask and replica layer ids in the effect tree
==========

to

==========
WIP: cc: Put mask and replica layer ids in the effect tree
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2016-06-10 23:06:56]

Description was changed from

==========
WIP: cc: Put mask and replica layer ids in the effect tree
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Put mask and replica layer ids in the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

[ajuma, 2016-06-10 23:09:48]

Description was changed from

==========
cc: Put mask and replica layer ids in the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

to

==========
cc: Put mask and replica layer ids in the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

[ajuma, 2016-06-10 23:09:48]

ajuma@chromium.org changed reviewers:
+ jaydasika@chromium.org, weiliangc@chromium.org

[ajuma, 2016-06-10 23:17:42]

Description was changed from

==========
cc: Put mask and replica layer ids in the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

to

==========
cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

[ajuma, 2016-06-10 23:18:04]

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/layer_tree_ho...
File cc/trees/layer_tree_host_common_unittest.cc (left):

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/layer_tree_ho...
cc/trees/layer_tree_host_common_unittest.cc:7913:
.maximum_animation_contents_scale);
Animation contents scale is no longer computed for mask layers, so these
expectations are obsolete (I should have removed them in the CL where we stopped
computing this).

[jaydasika, 2016-06-14 06:12:06]

lgtm

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/layer_tree_im...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/layer_tree_im...
cc/trees/layer_tree_impl.cc:1039: return nullptr;
Is this required ? If we had invalid id, we would be returning nullptr in line
1041 below.

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/tree_synchron...
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/tree_synchron...
cc/trees/tree_synchronizer.cc:22: void SynchronizeTreesInternal(LayerType*
layer_root,
I think layer_root is a redundant argument for this function. What PushLayerList
really needs is source_tree.

[ajuma, 2016-06-14 12:23:13]

Patchset #10 (id:180001) has been deleted

[ajuma, 2016-06-14 12:45:27]

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/layer_tree_im...
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/layer_tree_im...
cc/trees/layer_tree_impl.cc:1039: return nullptr;
On 2016/06/14 06:12:06, jaydasika wrote:
> Is this required ? If we had invalid id, we would be returning nullptr in line
> 1041 below.

Removed.

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/tree_synchron...
File cc/trees/tree_synchronizer.cc (right):

https://codereview.chromium.org/2035863003/diff/160001/cc/trees/tree_synchron...
cc/trees/tree_synchronizer.cc:22: void SynchronizeTreesInternal(LayerType*
layer_root,
On 2016/06/14 06:12:06, jaydasika wrote:
> I think layer_root is a redundant argument for this function. What
PushLayerList
> really needs is source_tree. 

Done. This also allowed merging PushLayerList and PushLayerListInternal, since
they were really only separate so that PushLayerList could get a tree from
layer_root and pass this tree to PushLayerListInternal.

[ajuma, 2016-06-14 12:46:31]

The CQ bit was checked by ajuma@chromium.org

[ajuma, 2016-06-14 12:46:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org
Link to the patchset: https://codereview.chromium.org/2035863003/#ps220001
(title: "Address review comments")

[commit-bot: I haz the power, 2016-06-14 12:46:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035863003/220001

[commit-bot: I haz the power, 2016-06-14 13:19:07]

Description was changed from

==========
cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

to

==========
cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

[commit-bot: I haz the power, 2016-06-14 13:19:08]

Committed patchset #11 (id:220001)

[commit-bot: I haz the power, 2016-06-14 13:19:16]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 13:21:20]

Description was changed from

==========
cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220
==========

to

==========
cc: Add mask and replica layer ids to the effect tree

This adds mask, replica, and replica mask layer ids to effect nodes,
removes mask_layer and replica_layer from LayerImpl, and adds
mask_layer and replica_layer to LayerImplTestProperties. With this
change, render surfaces can determine if they have a mask or replica
using their effect node rather than using their owning layer.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
BUG=612220

Committed: https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5
Cr-Commit-Position: refs/heads/master@{#399690}
==========

[commit-bot: I haz the power, 2016-06-14 13:21:21]

Patchset 11 (id:??) landed as
https://crrev.com/1d4026a36391cbac48d3d5fec5fe4a958807bea5
Cr-Commit-Position: refs/heads/master@{#399690}