cc/trees/damage_tracker.cc - Issue 2035863003: cc: Add mask and replica layer ids to the effect tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/damage_tracker.cc

Issue 2035863003: cc: Add mask and replica layer ids to the effect tree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/trees/damage_tracker.cc

diff --git a/cc/trees/damage_tracker.cc b/cc/trees/damage_tracker.cc

index c861025f1ee3bcb1cd91f40e354af8040e1efb5c..73e60f584ebff5819abd2d8b97e748e0c73ce96c 100644

--- a/cc/trees/damage_tracker.cc

+++ b/cc/trees/damage_tracker.cc

@@ -390,7 +390,7 @@ void DamageTracker::ExtendDamageForRenderSurface(

draw_transform, damage_rect_in_local_space);

target_damage_rect->Union(damage_rect_in_target_space);

- if (layer->replica_layer()) {

+ if (render_surface->HasReplica()) {

const gfx::Transform& replica_draw_transform =

render_surface->replica_draw_transform();

target_damage_rect->Union(MathUtil::MapEnclosingClippedRect(

@@ -401,8 +401,8 @@ void DamageTracker::ExtendDamageForRenderSurface(

// If there was damage on the replica's mask, then the target surface receives

// that damage as well.

- if (layer->replica_layer() && layer->replica_layer()->mask_layer()) {

- LayerImpl* replica_mask_layer = layer->replica_layer()->mask_layer();

+ if (render_surface->HasReplicaMask()) {

+ LayerImpl* replica_mask_layer = render_surface->ReplicaMaskLayer();

bool replica_is_new = false;

LayerRectMapData& data =

« no previous file with comments | « cc/test/layer_test_common.h ('k') | cc/trees/damage_tracker_unittest.cc » ('j') | no next file with comments »