Issue 203583004: Revert 168577 "Remove spurious check for invalid value."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203583004: Revert 168577 "Remove spurious check for invalid value." (Closed)

Created:
6 years, 9 months ago by dglazkov

Modified:
6 years, 9 months ago

Reviewers:
dglazkov

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

Revert 168577 "Remove spurious check for invalid value." > Remove spurious check for invalid value. > > The isCSSPrimitiveValue check is likely covering up parser bugs, > and toCSSPrimitiveValue has the assert to ensure we're not > doing something bad. > > R=eae,ksakamoto@chromium.org,timloh@chromium.org > BUG= > > Review URL: https://codereview.chromium.org/184103034 BUG=350509 TBR=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169456

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	trunk/Source/build/scripts/templates/StyleBuilder.cpp.tmpl	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r169456.