trunk/Source/build/scripts/templates/StyleBuilder.cpp.tmpl - Issue 203583004: Revert 168577 "Remove spurious check for invalid value."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

Issue 203583004: Revert 168577 "Remove spurious check for invalid value." (Closed) Base URL: svn://svn.chromium.org/blink/

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

===================================================================

--- trunk/Source/build/scripts/templates/StyleBuilder.cpp.tmpl (revision 169455)

+++ trunk/Source/build/scripts/templates/StyleBuilder.cpp.tmpl (working copy)

@@ -59,6 +59,8 @@

{%- if property.converter %}

{{ set_value(property) }}(StyleBuilderConverter::{{property.converter}}(state, value));

{%- elif property.font %}

+ if (!value->isPrimitiveValue())

+ return;

{{ set_value(property) }}(static_cast<{{property.type_name}}>(*toCSSPrimitiveValue(value)));

{%- else %}

{{ set_value(property) }}(static_cast<{{property.type_name}}>(*toCSSPrimitiveValue(value)));

« no previous file with comments | « no previous file | no next file » | no next file with comments »