Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 184103034: Remove spurious check for invalid value. (Closed)

Created:
6 years, 9 months ago by dglazkov
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Remove spurious check for invalid value. The isCSSPrimitiveValue check is likely covering up parser bugs, and toCSSPrimitiveValue has the assert to ensure we're not doing something bad. R=eae,ksakamoto@chromium.org,timloh@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/build/scripts/templates/StyleBuilder.cpp.tmpl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dglazkov
6 years, 9 months ago (2014-03-05 19:08:20 UTC) #1
eae
LGTM
6 years, 9 months ago (2014-03-05 19:08:43 UTC) #2
eae
The CQ bit was checked by eae@chromium.org
6 years, 9 months ago (2014-03-05 19:08:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/184103034/1
6 years, 9 months ago (2014-03-05 19:09:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:09:01 UTC) #5
commit-bot: I haz the power
Failed to apply patch for Source/build/scripts/templates/StyleBuilder.cpp.tmpl: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-05 19:09:01 UTC) #6
dglazkov
The CQ bit was checked by dglazkov@chromium.org
6 years, 9 months ago (2014-03-05 20:52:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/184103034/1
6 years, 9 months ago (2014-03-05 20:52:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dglazkov@chromium.org/184103034/1
6 years, 9 months ago (2014-03-05 21:01:05 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 05:53:40 UTC) #10
Message was sent while issue was closed.
Change committed as 168577

Powered by Google App Engine
This is Rietveld 408576698