DevTools: split protocol.json into files per domain.

DevTools: split protocol.json into files per domain.

BUG=580337
NOTRY=true

Committed: https://crrev.com/b34642153f00033ae8cdeea5bdb351f569c7ad7a
Cr-Commit-Position: refs/heads/master@{#397883}

[pfeldman, 2016-06-02 23:16:39]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-06-02 23:16:46]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 23:17:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035653005/1

[pfeldman, 2016-06-03 02:07:45]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 02:08:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035653005/10001

[dgozman, 2016-06-03 02:24:03]

lgtm

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:72: any(".json" in path for path
in local_paths) or
protocol/*.json

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:74:
any("InjectedScriptSource.js" in path for path in local_paths)):
While you are here, add DebuggerScript.js

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
(right):

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version:457:
domains_copy = copy.deepcopy(domains)
deepcopy inside compare_schemas

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/protocol/OWNERS (right):

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/protocol/OWNERS:1:
dgozman@chromium.org
set no-parent

[paulirish, 2016-06-03 02:37:05]

paulirish@chromium.org changed reviewers:
+ paulirish@chromium.org

[paulirish, 2016-06-03 02:37:06]

We should bump version of tot to 1.2 at least.

[paulirish, 2016-06-03 02:43:11]

On 2016/06/03 at 02:37:06, paulirish wrote:
> We should bump version of tot to 1.2 at least.

Or JavaScript/semver style would be "1.2-pre"

[commit-bot: I haz the power, 2016-06-03 04:36:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 04:36:52]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-06-03 05:19:49]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-06-03 05:20:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2035653005/10001

[pfeldman, 2016-06-03 05:21:21]

I'll address all in a follow-up.

[pfeldman, 2016-06-03 05:26:25]

Description was changed from

==========
DevTools: split protocol.json into files per domain.

BUG=580337
==========

to

==========
DevTools: split protocol.json into files per domain.

BUG=580337
==========

[pfeldman, 2016-06-03 05:26:25]

pfeldman@chromium.org changed reviewers:
+ skyostil@chromium.org

[pfeldman, 2016-06-03 05:26:51]

+skyostil for headless owners.

[commit-bot: I haz the power, 2016-06-03 05:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 05:28:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sami, 2016-06-03 09:40:47]

lgtm.

(I was going to try this locally, but "patch set is too large to download".
There's a headless_tests target in headless/ if you want to check things still
work.)

[pfeldman, 2016-06-03 17:07:33]

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:72: any(".json" in path for path
in local_paths) or
On 2016/06/03 02:24:02, dgozman wrote:
> protocol/*.json

Done.

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:74:
any("InjectedScriptSource.js" in path for path in local_paths)):
On 2016/06/03 02:24:02, dgozman wrote:
> While you are here, add DebuggerScript.js

Done.

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version
(right):

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/generate-inspector-protocol-version:457:
domains_copy = copy.deepcopy(domains)
On 2016/06/03 02:24:03, dgozman wrote:
> deepcopy inside compare_schemas

Done.

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/protocol/OWNERS (right):

https://codereview.chromium.org/2035653005/diff/10001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/protocol/OWNERS:1:
dgozman@chromium.org
On 2016/06/03 02:24:02, dgozman wrote:
> set no-parent

Done.

[pfeldman, 2016-06-03 17:44:59]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-03 17:45:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653005/#ps20001
(title: "addressed")

[commit-bot: I haz the power, 2016-06-03 17:45:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/20001

[pfeldman, 2016-06-03 18:32:53]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-06-03 22:17:25]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 22:18:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/30001

[pfeldman, 2016-06-03 23:27:28]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-03 23:27:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-03 23:27:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/40001

[dgozman, 2016-06-03 23:55:22]

still lgtm

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/inspector.gyp (right):

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/inspector.gyp:50: 'dependencies':
['protocol_version'],
It does not depend now.

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/inspector.gyp:62:
'browser_protocol.json',
../../platform/v8_inspector/js_protocol.json

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js
(right):

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackendHostedMode.js:125:
WebInspector.InspectorBackendHostedMode.loadFromJSONIfNeeded("../inspector.json");
protocol.json

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/BUILD.gn (right):

https://codereview.chromium.org/2035653005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/BUILD.gn:230:
action("inspector_protocol_version") {
Let's rename to validate.

[commit-bot: I haz the power, 2016-06-03 23:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 23:56:31]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pfeldman, 2016-06-04 00:07:40]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-04 00:07:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653005/#ps50001
(title: " ")

[commit-bot: I haz the power, 2016-06-04 00:08:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/50001

[pfeldman, 2016-06-04 00:11:15]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-04 00:11:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653005/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-06-04 00:11:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/60001

[pfeldman, 2016-06-04 00:12:03]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-06-04 00:14:16]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-06-04 00:14:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2035653005/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-06-04 00:14:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/80001

[pfeldman, 2016-06-04 01:23:24]

Description was changed from

==========
DevTools: split protocol.json into files per domain.

BUG=580337
==========

to

==========
DevTools: split protocol.json into files per domain.

BUG=580337
NOTRY=true
==========

[pfeldman, 2016-06-04 01:23:33]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-06-04 01:23:37]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-06-04 01:24:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2035653005/80001

[commit-bot: I haz the power, 2016-06-04 01:28:59]

Description was changed from

==========
DevTools: split protocol.json into files per domain.

BUG=580337
NOTRY=true
==========

to

==========
DevTools: split protocol.json into files per domain.

BUG=580337
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-04 01:29:01]

Committed patchset #9 (id:80001)

[commit-bot: I haz the power, 2016-06-04 01:30:23]

Description was changed from

==========
DevTools: split protocol.json into files per domain.

BUG=580337
NOTRY=true
==========

to

==========
DevTools: split protocol.json into files per domain.

BUG=580337
NOTRY=true

Committed: https://crrev.com/b34642153f00033ae8cdeea5bdb351f569c7ad7a
Cr-Commit-Position: refs/heads/master@{#397883}
==========

[commit-bot: I haz the power, 2016-06-04 01:30:25]

Patchset 9 (id:??) landed as
https://crrev.com/b34642153f00033ae8cdeea5bdb351f569c7ad7a
Cr-Commit-Position: refs/heads/master@{#397883}