Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/js_protocol-1.1.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp b/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
index 0c1b977cc7d6f81006bd1d7c005cb1b4ee919210..be8e11d709e66687c64097766da63d47d3dae44a 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
+++ b/third_party/WebKit/Source/platform/v8_inspector/v8_inspector.gyp
@@ -56,6 +56,7 @@
# GN version: //third_party/WebKit/Source/platform:inspector_protocol_sources
'target_name': 'protocol_sources',
'type': 'none',
+ 'dependencies': ['protocol_version'],
'actions': [
{
'action_name': 'generateV8InspectorProtocolBackendSources',
@@ -63,10 +64,11 @@
'<@(jinja_module_files)',
# The python script in action below.
'../inspector_protocol/CodeGenerator.py',
- # Input files for the script.
- '../../devtools/protocol.json',
+ # Source code templates.
'../inspector_protocol/TypeBuilder_h.template',
'../inspector_protocol/TypeBuilder_cpp.template',
+ # Protocol definitions
+ 'js_protocol.json',
],
'outputs': [
'<(blink_platform_output_dir)/v8_inspector/protocol/Debugger.cpp',
@@ -81,14 +83,38 @@
'action': [
'python',
'../inspector_protocol/CodeGenerator.py',
- '../../devtools/protocol.json',
- '--domains', 'Debugger,HeapProfiler,Profiler,Runtime',
+ '--protocol', 'js_protocol.json',
'--string_type', 'String16',
'--export_macro', 'PLATFORM_EXPORT',
'--output_dir', '<(blink_platform_output_dir)/v8_inspector/protocol',
'--output_package', 'platform/v8_inspector/protocol',
],
- 'message': 'Generating protocol backend sources from protocol.json',
+ 'message': 'Generating protocol backend sources from json definitions.',
+ },
+ ]
+ },
+ {
+ # GN version: //third_party/WebKit/Source/core/inspector:protocol_version
+ 'target_name': 'protocol_version',
+ 'type': 'none',
+ 'actions': [
+ {
+ 'action_name': 'generateV8InspectorProtocolVersion',
+ 'inputs': [
+ '../inspector_protocol/generate-inspector-protocol-version',
+ 'js_protocol.json',
+ ],
+ 'outputs': [
+ '<(blink_platform_output_dir)/v8_inspector/protocol.json',
+ ],
+ 'action': [
+ 'python',
+ '../inspector_protocol/generate-inspector-protocol-version',
+ '--o',
+ '<@(_outputs)',
+ 'js_protocol.json',
+ ],
+ 'message': 'Validate v8_inspector protocol for backwards compatibility and generate version file',
},
]
},
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/js_protocol-1.1.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698