Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: third_party/WebKit/Source/platform/BUILD.gn

Issue 2035653005: DevTools: split protocol.json into files per domain. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/BUILD.gn
diff --git a/third_party/WebKit/Source/platform/BUILD.gn b/third_party/WebKit/Source/platform/BUILD.gn
index 11bd520f0092f2c3ff4135c6f30121507882fd14..af41dd0d03f2e172816527cb96ad47111b9b7ef3 100644
--- a/third_party/WebKit/Source/platform/BUILD.gn
+++ b/third_party/WebKit/Source/platform/BUILD.gn
@@ -188,18 +188,18 @@ executable("character_data_generator") {
# Inspector protocol
-protocol_file = "../devtools/protocol.json"
-
action("inspector_protocol_sources") {
script = "inspector_protocol/CodeGenerator.py"
-
+ deps = [
+ ":inspector_protocol_version",
+ ]
sources = [
"inspector_protocol/CodeGenerator.py",
+ "inspector_protocol/TypeBuilder_cpp.template",
+ "inspector_protocol/TypeBuilder_h.template",
]
inputs = [
- protocol_file,
- "inspector_protocol/TypeBuilder_h.template",
- "inspector_protocol/TypeBuilder_cpp.template",
+ "v8_inspector/js_protocol.json",
]
outputs = [
"$blink_platform_output_dir/v8_inspector/protocol/Debugger.cpp",
@@ -213,9 +213,8 @@ action("inspector_protocol_sources") {
]
args = [
- rebase_path(protocol_file, root_build_dir),
- "--domains",
- "Debugger,HeapProfiler,Profiler,Runtime",
+ "--protocol",
+ rebase_path("v8_inspector/js_protocol.json", root_build_dir),
"--string_type",
"String16",
"--export_macro",
@@ -232,18 +231,18 @@ action("inspector_protocol_version") {
script = "inspector_protocol/generate-inspector-protocol-version"
inputs = [
- protocol_file,
+ "v8_inspector/js_protocol.json",
]
output_file =
- "$blink_platform_output_dir/inspector_protocol/InspectorProtocolVersion.h"
+ "$blink_platform_output_dir/v8_inspector/protocol/v8inspector.json"
outputs = [
output_file,
]
args = [
- "-o",
+ "--o",
rebase_path(output_file, root_build_dir),
- rebase_path(protocol_file, root_build_dir),
+ rebase_path("v8_inspector/js_protocol.json", root_build_dir),
]
}
@@ -294,7 +293,6 @@ group("make_platform_generated") {
":inspector_debugger_script",
":inspector_injected_script",
":inspector_protocol_sources",
- ":inspector_protocol_version",
":runtime_enabled_features",
]
}
@@ -322,7 +320,6 @@ component("platform") {
get_target_outputs(":inspector_debugger_script") +
get_target_outputs(":inspector_injected_script") +
get_target_outputs(":inspector_protocol_sources") +
- get_target_outputs(":inspector_protocol_version") +
get_target_outputs(":runtime_enabled_features")
configs += [

Powered by Google App Engine
This is Rietveld 408576698