Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
TBR=sadrul@chromium.org, ben@chromium.org

Committed: https://crrev.com/181cbc09384b9175d6de86f60b97b5a9aadd9711
Cr-Commit-Position: refs/heads/master@{#397585}

[Fady Samuel, 2016-06-02 20:11:18]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[Fady Samuel, 2016-06-02 20:11:26]

fsamuel@chromium.org changed reviewers:
+ sadrul@chromium.org

[Fady Samuel, 2016-06-02 20:12:39]

Description was changed from

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I'd going to address jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
==========

to

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
==========

[commit-bot: I haz the power, 2016-06-02 20:12:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034863002/1

[dtapuska, 2016-06-02 20:16:55]

dtapuska@chromium.org changed reviewers:
+ dtapuska@chromium.org

[dtapuska, 2016-06-02 20:16:56]

lgtm % one question

https://codereview.chromium.org/2034863002/diff/1/ui/base/ui_base_tests.gyp
File ui/base/ui_base_tests.gyp (right):

https://codereview.chromium.org/2034863002/diff/1/ui/base/ui_base_tests.gyp#n...
ui/base/ui_base_tests.gyp:163: 'selection_bound_unittest.cc',
Is this correct? I'd expect this line to be removed.

[commit-bot: I haz the power, 2016-06-02 20:28:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 20:28:49]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fady Samuel, 2016-06-02 20:38:32]

PTAL Sadrul for OWNERS

https://codereview.chromium.org/2034863002/diff/1/ui/base/ui_base_tests.gyp
File ui/base/ui_base_tests.gyp (right):

https://codereview.chromium.org/2034863002/diff/1/ui/base/ui_base_tests.gyp#n...
ui/base/ui_base_tests.gyp:163: 'selection_bound_unittest.cc',
On 2016/06/02 20:16:56, dtapuska wrote:
> Is this correct? I'd expect this line to be removed.

No it's not mass_rename error. Fixed. Thanks!

[Fady Samuel, 2016-06-02 20:38:38]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 20:39:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034863002/20001

[Fady Samuel, 2016-06-02 20:55:47]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 20:57:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034863002/40001

[commit-bot: I haz the power, 2016-06-02 21:27:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 21:27:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Fady Samuel, 2016-06-02 21:59:47]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 22:01:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034863002/60001

[Fady Samuel, 2016-06-02 23:29:37]

Description was changed from

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
==========

to

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
TBR=sadrul@chromium.org, ben@chromium.org
==========

[Fady Samuel, 2016-06-02 23:29:50]

The CQ bit was unchecked by fsamuel@chromium.org

[Fady Samuel, 2016-06-02 23:29:50]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2016-06-02 23:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2034863002/#ps60001
(title: "Updated views_unittests")

[commit-bot: I haz the power, 2016-06-02 23:30:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2034863002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2034863002/60001

[commit-bot: I haz the power, 2016-06-03 02:31:24]

Description was changed from

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
TBR=sadrul@chromium.org, ben@chromium.org
==========

to

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
TBR=sadrul@chromium.org, ben@chromium.org
==========

[commit-bot: I haz the power, 2016-06-03 02:31:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-03 02:35:10]

Description was changed from

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
TBR=sadrul@chromium.org, ben@chromium.org
==========

to

==========
Move SelectionBound from ui/base/touch to ui/gfx to be used by cc

We need to be able to serialize CompositorFrames over mojo which depend
(indirectly) on cc::ViewportSelectionBound. To avoid writing two serializers for
two very similar structs, I've addressed jdduke@'s TODO to unify
the two SelectionBounds. As a first step, this CL moves SelectionBound to a
directory that can be used by cc.

BUG=611802
TBR=sadrul@chromium.org, ben@chromium.org

Committed: https://crrev.com/181cbc09384b9175d6de86f60b97b5a9aadd9711
Cr-Commit-Position: refs/heads/master@{#397585}
==========

[commit-bot: I haz the power, 2016-06-03 02:35:12]

Patchset 4 (id:??) landed as
https://crrev.com/181cbc09384b9175d6de86f60b97b5a9aadd9711
Cr-Commit-Position: refs/heads/master@{#397585}

[sadrul, 2016-06-03 07:59:12]

lgtm