Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2034573004: FYI: Adds V8PrivateProperty::getOrUndefined(). (Closed)

Created:
4 years, 6 months ago by Yuki
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, haraken, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FYI: Adds V8PrivateProperty::getOrUndefined(). BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -115 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.h View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h View 2 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLProgram.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 3 chunks +2 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 15 chunks +34 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h View 3 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
Yuki
Description was changed from ========== FYI: Adds V8PrivateProperty::getOrUndefined(). BUG= ========== to ========== FYI: Adds V8PrivateProperty::getOrUndefined(). ...
4 years, 6 months ago (2016-06-02 13:05:12 UTC) #1
Yuki
4 years, 6 months ago (2016-06-07 09:29:55 UTC) #2 
Description was changed from

==========
FYI: Adds V8PrivateProperty::getOrUndefined().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
FYI: Adds V8PrivateProperty::getOrUndefined().

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

Powered by Google App Engine
This is Rietveld 408576698