Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2034503003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //sync (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
stanisc
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //sync The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/3a5b7518624811dc26a64242b8dcbdf5a8e3632f Cr-Commit-Position: refs/heads/master@{#397627}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M sync/internal_api/js_sync_encryption_handler_observer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/test/fake_server/fake_server.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:23:25 UTC) #2
stanisc
lgtm
4 years, 6 months ago (2016-06-02 23:10:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034503003/1
4 years, 6 months ago (2016-06-03 00:56:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/232729)
4 years, 6 months ago (2016-06-03 03:00:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2034503003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2034503003/1
4 years, 6 months ago (2016-06-03 03:20:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 04:21:33 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 04:23:28 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a5b7518624811dc26a64242b8dcbdf5a8e3632f
Cr-Commit-Position: refs/heads/master@{#397627}

Powered by Google App Engine
This is Rietveld 408576698