Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: sync/internal_api/js_sync_encryption_handler_observer_unittest.cc

Issue 2034503003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //sync (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sync/test/fake_server/fake_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/js_sync_encryption_handler_observer_unittest.cc
diff --git a/sync/internal_api/js_sync_encryption_handler_observer_unittest.cc b/sync/internal_api/js_sync_encryption_handler_observer_unittest.cc
index 30d9b0053f2ab844d8fc4a2607beb19c20174a72..d8b18a508c72acea0e8586ac677b4562fe6e3167 100644
--- a/sync/internal_api/js_sync_encryption_handler_observer_unittest.cc
+++ b/sync/internal_api/js_sync_encryption_handler_observer_unittest.cc
@@ -119,8 +119,7 @@ TEST_F(JsSyncEncryptionHandlerObserverTest, OnEncryptedTypesChanged) {
for (int i = FIRST_REAL_MODEL_TYPE; i < MODEL_TYPE_COUNT; ++i) {
ModelType type = ModelTypeFromInt(i);
encrypted_types.Put(type);
- encrypted_type_values->Append(new base::StringValue(
- ModelTypeToString(type)));
+ encrypted_type_values->AppendString(ModelTypeToString(type));
}
EXPECT_CALL(mock_js_event_handler_,
« no previous file with comments | « no previous file | sync/test/fake_server/fake_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698